Migrate NativeSampleTurboModule to codegen integration - RFC (#56723) - #56723
Closed
christophpurrer wants to merge 1 commit into
Closed
christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104323543. |
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 8, 2026
…6723) Summary: Replace hand-written spec files for `NativeSampleTurboModule` with proper codegen integration by removing exclusion rules and configuring the module in `package.json`. This eliminates ~1600 lines of manual boilerplate (Java, C++, Objective-C) across Android, iOS, and macOS platforms, allowing the codegen system to generate these files automatically from the JavaScript spec. Changelog: [Internal] Differential Revision: D104323543
christophpurrer
force-pushed
the
export-D104323543
branch
from
May 8, 2026 15:29
f41a976 to
37b7f10
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 8, 2026
…6723) Summary: Replace hand-written spec files for `NativeSampleTurboModule` with proper codegen integration by removing exclusion rules and configuring the module in `package.json`. This eliminates ~1600 lines of manual boilerplate (Java, C++, Objective-C) across Android, iOS, and macOS platforms, allowing the codegen system to generate these files automatically from the JavaScript spec. Changelog: [Internal] Differential Revision: D104323543
christophpurrer
force-pushed
the
export-D104323543
branch
from
May 8, 2026 16:54
37b7f10 to
04dfb4e
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 8, 2026
…6723) Summary: Replace hand-written spec files for `NativeSampleTurboModule` with proper codegen integration by removing exclusion rules and configuring the module in `package.json`. This eliminates ~1600 lines of manual boilerplate (Java, C++, Objective-C) across Android, iOS, and macOS platforms, allowing the codegen system to generate these files automatically from the JavaScript spec. Changelog: [Internal] Differential Revision: D104323543
christophpurrer
force-pushed
the
export-D104323543
branch
from
May 8, 2026 17:34
04dfb4e to
22d3f32
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 8, 2026
…6723) Summary: Replace hand-written spec files for `NativeSampleTurboModule` with proper codegen integration by removing exclusion rules and configuring the module in `package.json`. This eliminates ~1600 lines of manual boilerplate (Java, C++, Objective-C) across Android, iOS, and macOS platforms, allowing the codegen system to generate these files automatically from the JavaScript spec. Changelog: [Internal] Differential Revision: D104323543
christophpurrer
force-pushed
the
export-D104323543
branch
from
May 8, 2026 18:48
22d3f32 to
b9e1698
Compare
…6723) Summary: Replace hand-written spec files for `NativeSampleTurboModule` with proper codegen integration by removing exclusion rules and configuring the module in `package.json`. This eliminates ~1600 lines of manual boilerplate (Java, C++, Objective-C) across Android, iOS, and macOS platforms, allowing the codegen system to generate these files automatically from the JavaScript spec. Changelog: [Internal] Differential Revision: D104323543
christophpurrer
force-pushed
the
export-D104323543
branch
from
May 9, 2026 00:20
b9e1698 to
33ae88b
Compare
|
This pull request has been merged in 734f5c1. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in 734f5c1 When will my fix make it into a release? | How to file a pick request? |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Sep 16, 2026
…58516) Summary: #56723 moved `SampleTurboModule`'s `unstableRequiresMainQueueSetup` annotation from rn-tester's `codegenConfig` into react-native's. Codegen collects these annotations from every library and emits them into `RCTUnstableModulesRequiringMainQueueSetupProvider`, so every app now lists `SampleTurboModule`, and `RCTInstance` eagerly requests it at startup. The native class only ships with rn-tester, so every other app logs "Unable to find module for SampleTurboModule", which is a redbox in development. The annotation is keyed by module name and does not need to live next to the spec, so move it back to rn-tester, the one app that links the class. Running the generator with react-native alone now yields the six core modules; adding rn-tester's config yields the same list plus `SampleTurboModule`. Changelog: [iOS] [Fixed] - Stop apps from requesting the sample TurboModule that only rn-tester provides Pull Request resolved: #58516 Test Plan: Ran `generateUnstableModulesRequiringMainQueueSetupProvider` against `packages/react-native` alone and against `packages/react-native` plus `packages/rn-tester`: rn-only: AccessibilityManager, Appearance, AppState, DeviceInfo, PlatformConstants, StatusBarManager with-rn-tester: AccessibilityManager, Appearance, AppState, DeviceInfo, PlatformConstants, StatusBarManager, SampleTurboModule Reproduced the redbox in Expo Go on 0.87.0, 0.87.1 and 0.88.0-rc.0. Reviewed By: cipolleschi Differential Revision: D120190436 Pulled By: christophpurrer fbshipit-source-id: b1991cca7d8bce889e57866eb507e4259f61425f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace hand-written spec files for
NativeSampleTurboModulewith proper codegen integration by removing exclusion rules and configuring the module inpackage.json. This eliminates ~1600 lines of manual boilerplate (Java, C++, Objective-C) across Android, iOS, and macOS platforms, allowing the codegen system to generate these files automatically from the JavaScript spec.Changelog: [Internal]
Differential Revision: D104323543